Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @nextcloud/vue to v8.0.0-beta.8 #10626

Merged
merged 9 commits into from
Oct 11, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 1, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
unread messages / unread mentions image image unread messages / unread mentions Screenshot from 2023-10-02 18-04-53 image
image image image image
image image
image image
Screenshot from 2023-10-09 11-28-09 image image image
image image
image image

🚧 Tasks

  • Migration
  • Check used components
    • NcActionButton
    • NcActionButtonGroup
    • NcActionInput
    • NcActionLink
    • NcActions
    • NcActionSeparator
    • NcActionText
    • NcAppContent
    • NcAppNavigation
    • NcAppNavigationCaption
    • NcAppSettingsDialog
    • NcAppSettingsSection
    • NcAppSidebar
    • NcAppSidebarTab
    • NcAvatar
    • NcButton
    • NcCheckboxRadioSwitch
    • NcColorPicker
    • NcContent
    • NcCounterBubble
    • NcDashboardWidget
    • NcDashboardWidgetItem
    • NcDateTimePicker
    • NcEmojiPicker
    • NcEmptyContent
    • NcListItem
    • NcLoadingIcon
    • NcModal
    • NcNoteCard
    • NcPasswordField
    • NcPopover
    • NcProgressBar
    • NcRelatedResourcesPanel
    • NcRichContenteditable
      fix backend for NcAutocompleteResult (provide title instead of label or both)
      provide compatibility for frontend and mobile clients (endpoint: chat/{token}/mentions)
    • NcRichText
    • NcSelect
    • NcTextField
    • NcUserBubble
  • Check used mixins
    • isMobile
    • richEditor
  • Check used directives
    • Tooltip
  • Check used functions
    • usernameToColor
  • Jest
  • Lint
    • Omit eslint n/no-missing-import for library components
    • Replace with analogs
  • Design
    • Check style changes
      • NcListItem - BG color in active state
      • NcEmptyContent - don't fill an empty space, need to set height: 100%

🏁 Checklist

@Antreesy Antreesy added 2. developing design feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Oct 1, 2023
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Oct 1, 2023
@Antreesy Antreesy self-assigned this Oct 1, 2023
@Antreesy Antreesy force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch 2 times, most recently from 7cb5c08 to 41a3277 Compare October 2, 2023 11:35
@Antreesy Antreesy force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from 425abd0 to 9baf377 Compare October 8, 2023 21:04
@Antreesy Antreesy changed the title chore: bump @nextcloud/vue to v8.0.0-beta.7 chore: bump @nextcloud/vue to v8.0.0-beta.8 Oct 8, 2023
@Antreesy Antreesy force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from 9baf377 to 5acdc26 Compare October 9, 2023 13:36
@Antreesy Antreesy marked this pull request as ready for review October 9, 2023 13:37
@@ -706,6 +706,11 @@ export default {
const possibleMentions = response.data.ocs.data

possibleMentions.forEach(possibleMention => {
// TODO fix backend for userMention
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not, because other clients rely on the naming,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll guess it will be better to patch response on web-client only, rather then provide both label and name?

.eslintrc.js Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from 5acdc26 to a7c1ed7 Compare October 10, 2023 09:35
jest.config.js Show resolved Hide resolved
Set height to 100%, align icon within empty space

Signed-off-by: Maksim Sukharev <[email protected]>
Fix scroll and paddings due to new wrapper, fix close button

Signed-off-by: Maksim Sukharev <[email protected]>
Replace *title prop => *name prop

Signed-off-by: Maksim Sukharev <[email protected]>
rename import, remove deep styles, fix appearance

Signed-off-by: Maksim Sukharev <[email protected]>
…cDateTimePicker

rename imports, remove or replace outdated props
Signed-off-by: Maksim Sukharev <[email protected]>
transform backend response for UserMention

Signed-off-by: Maksim Sukharev <[email protected]>
rename *title => *name props, adjust tests, remove deep styles

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the deps/nextcloud/vue-8.0.0-beta.7 branch from a7c1ed7 to 948a640 Compare October 10, 2023 15:36
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and good to go.


&__loading,
&__empty-content {
flex: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to ? as empty content has flex-grow: 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for &__loading seems to be required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow-up 👀

@Antreesy Antreesy merged commit 1e62e8f into master Oct 11, 2023
37 checks passed
@Antreesy Antreesy deleted the deps/nextcloud/vue-8.0.0-beta.7 branch October 11, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing dependencies Pull requests that update a dependency file design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants